-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update SidecarContainers to stable in v1.33 #49685
base: dev-1.33
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @SergeyKanzhelev |
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
65711f3
to
6bca998
Compare
/cc @gjkim42 |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but we also need to reword https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/#pod-sidecar-containers because the feature gate will no longer control behavior.
You should change this page or ask another contributor to help with the revision.
@pacoxu if you can rally someone from SIG Node who is keen to help, https://kubernetes.io/docs/tutorials/configuration/pod-sidecar-containers/ is not yet quite at the quality level we'd like for beta. That fact doesn't block graduation but if we can improve that tutorial and polish it more, even better.
content/en/docs/reference/command-line-tools-reference/feature-gates/SidecarContainers.md
Show resolved
Hide resolved
…-gates/SidecarContainers.md Co-authored-by: Dipesh Rawat <[email protected]>
I find that #46525 did some rephrase based on @matthyx 's #43471 beta update doc PR. https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#termination-with-sidecars(and some context above this ) @matthyx @SergeyKanzhelev for GA, do we want to publish a blog?
I could help on improve that part based on merged KEP and merged PRs. |
yes and a celebration in London ! |
To improve https://kubernetes.io/docs/tutorials/configuration/pod-sidecar-containers/:
|
On the tutorial, I also recommend illustrating general good practice; for example, have a Pod template with a selector on |
ref to kubernetes/enhancements#753