-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove jobs from sig-node-presubmits.yaml and generate them for dra-canary.yaml using jinja #34163
base: master
Are you sure you want to change the base?
remove jobs from sig-node-presubmits.yaml and generate them for dra-canary.yaml using jinja #34163
Conversation
…anary.yaml using jinja
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elieser1101 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @elieser1101. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -254,3 +254,97 @@ presubmits: | |||
requests: | |||
cpu: 2 | |||
memory: 9Gi | |||
|
|||
- name: pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2-canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't have to create "kubetest2-canary". Just modify the existing "canary" job.
That conflicts with other, concurrent changes to canary, like my timeout changes. In practice, most of the time we are only going to try one experimental change at a time, so that should be okay.
Let me wrap up my experimental work by merging it into the main jobs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaces #34068
Will this be the way to go?
cc: @bart0sh @pohly
ref: #32567