Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch-protection-periodic: add allow_job_disabled_policies #34143

Conversation

danilo-gemoli
Copy link
Contributor

Trying to fix #33900 (comment) this time.

The current configuration requires the entire kubernetes-sigs to be branch-protected, but as it can be seen from here, there is at least one repository that opts out of that.

As an example:

branch-protection:
  orgs:
    kubernetes-sigs:
      protect: true
      repos:
        external-dns:
          branches:
            gh-pages:
              protect: false

Adding allow_disabled_job_policies: true should solve the problem, hopefully.

Relevant code here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2025
@danilo-gemoli
Copy link
Contributor Author

/cc @BenTheElder

@dims
Copy link
Member

dims commented Jan 14, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit b8e4746 into kubernetes:master Jan 14, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@danilo-gemoli: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

Trying to fix #33900 (comment) this time.

The current configuration requires the entire kubernetes-sigs to be branch-protected, but as it can be seen from here, there is at least one repository that opts out of that.

As an example:

branch-protection:
 orgs:
   kubernetes-sigs:
     protect: true
     repos:
       external-dns:
         branches:
           gh-pages:
             protect: false

Adding allow_disabled_job_policies: true should solve the problem, hopefully.

Relevant code here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

branchprotector continuously failing
3 participants