-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codesearch periodic job to run different script #26105
Conversation
is it possible to update the interval time do it only twice a week during working days ? we don't restart the instance every day. For the existing instance, the restart is only once a week. |
Yup, sure thing! Looks like we can use But if you have a better suggestion for days/times I'm happy to adjust. I just took a random guess :) |
I'm totally fine with that. We can revist later if needed. /approve Remove the hold when kubernetes/k8s.io#3679 is merged. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, jimdaga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/uncc |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Resolves: kubernetes/k8s.io#2182
Supporting PR: kubernetes/k8s.io#3679
This PR updates the
periodic-k8sio-deploy-app-codesearch
job to run the newrestart.sh
script.The
deploy.sh
doesn't trigger an app restart unless there are changes, so usingrestart.sh
(this runs arollout restart deployment
) makes more sense.This will ensure we restart codesearch daily and update search indexes to include any new git changes.
Since we are using rolling upgrades with health checks, restarts will (should) NOT cause downtime.