-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to inject additional measurements to load config #2483
Conversation
/assign @mborsz |
/retest |
It looks like tests failures are unrelated to my change as clusterloader is not able to ssh on to the master:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Argh4k, mborsz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Tests are failing with:
|
Why do we use N2 in our tests? it seems to be quite new |
I will raise this in sig-testing slack channel. |
/retest |
/retest |
/retest |
@Argh4k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dlapcevic unfortunately all the information that I have are from the slack thread that I posted here :( |
@mborsz can we push it through? Clusterloader2 test is failing with N2 quota issue and clusterloader2-kubemark is failing with:
They do not seem to be connected to my CL. For testing I've set up a simple test with measurments in file one directory above and run the clusterloader with that. I'm attaching files and generatedConfig for that (they are formatted as txt but in reality those are yamls as github does not allow to attach yamls in the comment) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows to inject additional measurements via CL2_ADDITIONAL_MEASURMENT_MODULES to load/config.yaml.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: