-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert path to slashes before passing to build.Context.Import() #167
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @al45tair! |
Hm, I think this code is part of trying to figure out what the right import path should be for the given directory. So this seems... hacky, but the code here is already pretty questionable, so ok I guess? (but you need to sign the CLA) |
On UNIX systems, we get away with the existing code because filesystem and package paths both use the same kind of separator. On Windows, sadly, that isn't the case and that causes everything to go wrong (more specifically, we end up not being able to detect that this is a local package, and so the output path for the generated files is wrong). See issue kubernetes#166.
How can we test this continuously? |
I filed #174. I definitely expect regressions for things that aren't tested. But I think blocking a 1 line change for lack of a big testing setup is maybe overkill. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: al45tair, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On UNIX systems, we get away with the existing code because filesystem
and package paths both use the same kind of separator. On Windows,
sadly, that isn't the case and that causes everything to go wrong
(more specifically, we end up not being able to detect that this is a
local package, and so the output path for the generated files is
wrong).
Fixes issue #166.