-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4951: Add PRR file. #5094
base: master
Are you sure you want to change the base?
KEP-4951: Add PRR file. #5094
Conversation
Hi @jm-franc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @deads2k |
/assign @gjtempleton |
/hold [To ensure this isn't automatically merged before both PRR and SIG lead reviewed.] |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jm-franc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions from me.
- [ ] Other (treat as last resort) | ||
- Details: | ||
- [X] Events | ||
- Event Reason: `SuccessfulRescale` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be enough to tell users that it was scaling using the configured, non-global level tolerance?
Feel like this falls under the same challenge as linked out to in the missing metrics section.
- [X] Events | ||
- Event Reason: `SuccessfulRescale` | ||
|
||
Users can monitor the scaling behavior of their HPA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide more detail here - do we have an idea of what signals they might be able to look at - would they need to do some maths to check the tolerance level being applied, or do we foresee some debug level logging being available with this information?
Add files needed to start the PRR process.
Issue link.