Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4816 DRA Prioritized List design update #5065

Merged
merged 1 commit into from
Jan 31, 2025
Merged

KEP-4816 DRA Prioritized List design update #5065

merged 1 commit into from
Jan 31, 2025

Conversation

mortent
Copy link
Member

@mortent mortent commented Jan 21, 2025

  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025
@mortent mortent force-pushed the UpdatePrioritizedListKEP branch 2 times, most recently from a35f54d to febe8e3 Compare January 21, 2025 18:44
@mortent
Copy link
Member Author

mortent commented Jan 21, 2025

/assign @johnbelamaric

@mortent mortent force-pushed the UpdatePrioritizedListKEP branch from febe8e3 to 2d7df62 Compare January 22, 2025 18:55
@johnbelamaric
Copy link
Member

/lgtm

I think the name could change, but I am OK merging this as-is, and deferring the exact name discussion to the implementation PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
@mortent mortent force-pushed the UpdatePrioritizedListKEP branch from ce1798e to 105bcfa Compare January 25, 2025 22:37
@dom4ha
Copy link
Member

dom4ha commented Jan 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@johnbelamaric
Copy link
Member

/lgtm

@alculquicondor PTAL

@alculquicondor
Copy link
Member

cc @macsko

@alculquicondor
Copy link
Member

cc @sanposhiho

@johnbelamaric
Copy link
Member

@mortent can you update the latest-milestone and the milestone values in the kep.yaml for 1.33?

@mortent mortent force-pushed the UpdatePrioritizedListKEP branch from 105bcfa to 9b90cd9 Compare January 28, 2025 21:40
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2025
@mortent
Copy link
Member Author

mortent commented Jan 28, 2025

Updated the milestone fields in kep.yaml.

@mortent mortent force-pushed the UpdatePrioritizedListKEP branch from ee2be69 to 825d54d Compare January 30, 2025 21:45
@alculquicondor
Copy link
Member

/approve
from SIG scheduling

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@mortent mortent force-pushed the UpdatePrioritizedListKEP branch from 825d54d to 518d18a Compare January 31, 2025 16:17
pohly
pohly reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise LGTM from me.

@mortent mortent force-pushed the UpdatePrioritizedListKEP branch from 518d18a to 12e07eb Compare January 31, 2025 17:01
johnbelamaric
johnbelamaric reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@johnbelamaric
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2025
@johnbelamaric
Copy link
Member

holding for @pohly's approval. sorry didn't think and did the lgtm. @pohly please release the old when you approve

@johnbelamaric
Copy link
Member

/approve

is what I should have done!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, johnbelamaric, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly
Copy link
Contributor

pohly commented Jan 31, 2025

/lgtm
/hold cancel

Thanks everyone!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit de1e839 into kubernetes:master Jan 31, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 31, 2025
@mortent
Copy link
Member Author

mortent commented Feb 4, 2025

/wg device-management

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Feb 4, 2025
@johnbelamaric johnbelamaric mentioned this pull request Feb 10, 2025
Open
4 tasks
@bianbbc87 bianbbc87 mentioned this pull request Feb 10, 2025
Open
4 tasks
@mortent mortent mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@alculquicondor alculquicondor alculquicondor left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@dom4ha dom4ha dom4ha left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@pohly pohly

@johnbelamaric johnbelamaric

@dom4ha dom4ha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
SIG Scheduling
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
6 participants
@mortent @johnbelamaric @dom4ha @alculquicondor @k8s-ci-robot @pohly