-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added NoExecute taint to terminating Nodes #626
Conversation
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Hey @sadath-12. I'd discuss more on the issue with @njtran about this one. He is driving the design around this issue and is planning to put together an RFC around the implications of this design. This change has a number of implications, once of which is that adding a |
Sure,Thanks @jonathan-innis |
Signed-off-by: sadath-12 <[email protected]>
Added some information on the #629. I think this PR/Design should be explored and iterated on after that is completed, which I believe is the opposite as what you've described. |
Sure @njtran |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #624 Part 4 (Terminating:NoExecute Taint)
Description
This pr attempts to solve issue of #621 as mentioned #624 . Tainting the nodes as
NoExecute
before attempting to terminate and also along side tries to make the taints operation code structure a bit more scalable and reusableHow was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.