Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix broken links on site #3655

Merged
merged 1 commit into from
Mar 4, 2025
Merged

docs: Fix broken links on site #3655

merged 1 commit into from
Mar 4, 2025
+9 −7

Conversation

blake
Copy link
Contributor

@blake blake commented Mar 3, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:

This commit fixes a few links that were incorrectly being rendered as markdown instead of HTML anchors, or were pointing to invalid URLs.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@blake
docs: Fix broken links on site

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
09a38dd 
This commit fixes a few links that were incorrectly being rendered as
markdown instead of HTML anchors, or were pointing to invalid URLs.

* Fixed a broken link to GEP States in GEP-91. Page was moved to a new
  location in kubernetes-sigs#1440 and section heading was renamed in kubernetes-sigs#2689.
* Fixed a broken anchor link in GEP-713. Missed in kubernetes-sigs#2448 when section header
  was updated.
* Fixed link to policy attachment docs in GEP-1323.
* Fixed link to ListenerSets GitHub issue in GEP-1713.
* Fixed link to Envoy's RequestMirrorPolicy route action in GEP-3171.
* Fixed link to Flomesh Gateway API on implementations page.

Signed-off-by: Blake Covarrubias <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @blake. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@blake blake mentioned this pull request Mar 3, 2025
Merged
@robscott
Copy link
Member

robscott commented Mar 4, 2025

Thank @blake!

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blake, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2025
@robscott
Copy link
Member

robscott commented Mar 4, 2025

No meaningful changes to GEPs, just fixing links. Removing the auto-hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 946c500 into kubernetes-sigs:main Mar 4, 2025
13 checks passed
@blake blake deleted the blake/fix-broken-links branch March 5, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca

@youngnick youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blake @k8s-ci-robot @robscott