-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra newlines and format descriptions of items #3574
base: main
Are you sure you want to change the base?
Conversation
Hi @snorwin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a great improvement, thanks @snorwin! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d101b4b
to
2a8d20b
Compare
New changes are detected. LGTM label has been removed. |
Signed-off-by: Norwin Schnyder <[email protected]>
2a8d20b
to
101e140
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The standard CRD still contains gateway:experimental:description as the Custom Gateway API Tweaks in the descriptions of items are not processed. In addition, the descriptions contain many extra newlines, which cause them to fail the yaml-lint check (https://github.com/adrienverge/yamllint/blob/master/yamllint/rules/empty_lines.py).
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: