Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP 1767: CORS Filter #3435

Merged
merged 33 commits into from
Feb 6, 2025
Merged

GEP 1767: CORS Filter #3435

merged 33 commits into from
Feb 6, 2025

Conversation

lianglli
Copy link
Contributor

@lianglli lianglli commented Nov 5, 2024

What type of PR is this?
/kind gep

What this PR does / why we need it:
This GEP proposes to add a new field HTTPCORSFilter to HTTPRouteFilter.

Which issue(s) this PR fixes:
Fixes #1767

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @lianglli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 5, 2024
@youngnick
Copy link
Contributor

Thanks for the energy here @liangli, but the correct process here is for you to add some discussion about this feature to the proposed set of Experimental changes in #3403, and then, if this CORS GEP is selected for an Experimental slot by the community's voting, this PR will be able to move forward.

This is a useful feature that already has a GEP, has been discussed before, and is not too big, so it's reasonably likely that it will be included if we can free up enough Experimental slots by moving things to Standard.

I note that you added this to the 1.2 Experimental discussion as well, so it's fine to just reuse the same description in the v1.3 scoping discussion there so that any new folks will have the context to vote.

Until then, sadly, this PR will need to be on hold.

/hold

@robscott
Copy link
Member

robscott commented Dec 6, 2024

Thanks for writing up this GEP @lianglli! This made the cut for v1.3 release scoping, it's great to already have a GEP PR ready for review, will take a look shortly.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2024
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this @lianglli! This is incredibly detailed and well written. I took a first pass and left some initial comments.

/cc @strongjz @howardjohn @youngnick

geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
@robscott robscott added this to the v1.3.0 milestone Dec 7, 2024
Copy link
Contributor

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the GEP -- top notch details!

geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/metadata.yaml Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
geps/gep-1767/index.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 27, 2025
@robscott
Copy link
Member

Thanks for all the work on this @lianglli!

/lgtm
/approve
/release-note-none

Although I reopened a couple comment threads that I think could use a bit more discussion, they're clearly small enough to cover when we get into the next phase of the enhancement process with additions to API types.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 31, 2025
geps/gep-1767/index.md Outdated Show resolved Hide resolved
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this, @lianglli!

/approve

@robscott
Copy link
Member

Thanks for all the work on this @lianglli!

I'll hold off on merging this until the most recent comment has been resolved, but IMO this is sufficiently close to keep it in the v1.3 milestone and on to the next phase.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 5, 2025
@lianglli lianglli requested review from htuch and mlavacca February 5, 2025 04:32
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 5, 2025
@lianglli lianglli force-pushed the gep-1767 branch 2 times, most recently from bbd9b4d to fbe44b1 Compare February 5, 2025 06:14
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lianglli, mlavacca, robscott, spacewander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

robscott commented Feb 6, 2025

Thanks @lianglli!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit d257136 into kubernetes-sigs:main Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GEP: Add support for CORS
10 participants