Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separates EnvoyExtensionPolicy from Ext Proc #200

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Separates EnvoyExtensionPolicy from Ext Proc #200

merged 2 commits into from
Jan 25, 2025

Conversation

danehans
Copy link
Contributor

  • Separates EnvoyExtensionPolicy custom resource from resources required to run EPP.
  • Updates POC readme with steps to apply the new manifest.

Fixes #199
Supports #77

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g January 15, 2025 04:21
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liu-cong January 15, 2025 04:21
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 15, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 8ebe6ed
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/6794194207594900082e2a5a
😎 Deploy Preview https://deploy-preview-200--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 15, 2025

@danehans I think we need to do more to clean this up; what do you think of #202?

@ahg-g
Copy link
Contributor

ahg-g commented Jan 21, 2025

@danehans I think we need to do more to clean this up; what do you think of #202?

@danehans what do you think?

@danehans
Copy link
Contributor Author

Yes, add'l cleanup is needed but this PR is a simple step in the right direction. As I stated here, I'm in favor of using Envoy with a static config for a quick start guide. It's a simplified process, reduces deps, and allows the project to not show a gateway implementation preference. Thoughts?

ahg-g
ahg-g reviewed Jan 24, 2025
View reviewed changes
pkg/manifests/extension_policy.yaml
@@ -0,0 +1,31 @@
apiVersion: gateway.envoyproxy.io/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still exists in ext_proc.yaml, do we need it in both places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not required for EPP, it's an Envoy Gateway requirement. I forgot to remove it so thanks for the heads-up. Commit 8ebe6ed removes the duplicate EnvoyExtensionPolicy, PTAL.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c49986 into kubernetes-sigs:main Jan 25, 2025
8 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jan 27, 2025
@danehans @kfswain
Separates EnvoyExtensionPolicy from Ext Proc (kubernetes-sigs#200)
942c0c0 
* Separates EnvoyExtensionPolicy from Ext Proc

Signed-off-by: Daneyon Hansen <[email protected]>

* Removes dplicative EnvoyExtensionPolicy from manifests

Signed-off-by: Daneyon Hansen <[email protected]>

---------

Signed-off-by: Daneyon Hansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Off EnvoyExtensionPolicy from ext_proc.yaml
3 participants
@danehans @ahg-g @k8s-ci-robot