-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure machine pools are deleted before gke cluster #1458
base: main
Are you sure you want to change the base?
fix: make sure machine pools are deleted before gke cluster #1458
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Carlos Salas <[email protected]>
2aefcfa
to
7abfdae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexander-demicev, salasberryfin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
During cluster deletion, a
GCPManagedCluster
may be deleted before its associatedGCPManagedMachinePool
/s which actually needs the cluster resource to exist to delete successfully:This happens intermittently and it's hard to reproduce, but there needs to be logic that waits for the machine pools to be removed before continuing with deleting the cluster.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is similar to this CAPA issue.
TODOs:
Release note: