-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vpc support #416
base: main
Are you sure you want to change the base?
Add vpc support #416
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishesh92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e5f7889
to
6575d76
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 25.66% 25.61% -0.06%
==========================================
Files 59 69 +10
Lines 5563 6699 +1136
==========================================
+ Hits 1428 1716 +288
- Misses 3996 4824 +828
- Partials 139 159 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9cde0a8
to
8a20c54
Compare
/test all |
Test Results : (tid-531)
|
8a20c54
to
53f6a19
Compare
53f6a19
to
0ad69e1
Compare
Test Results : (tid-532)
|
@vishesh92 |
I ran the test suite only for the failing test and it was successful. Probably some other test is causing issues with this one. |
@weizhouapache Invalid command: /run-e2e -c 4.20
The command to run e2e test for CAPC. Usage: /run-e2e [-k Kubernetes_Version] [-c CloudStack_Version] [-h Hypervisor] [-i Template/Image] [-f Kubernetes_Version_Upgrade_From] [-t Kubernetes_Version_Upgrade_To]
Examples:
|
/run-e2e -c 4.20 |
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
Setting up environment failed |
Test Results : (tid-543)
|
Test Results : (tid-546)
|
Setting up environment failed |
Test Results : (tid-549)
|
@vishesh92 Can you add a e2e test to create a cluster in a VPC in a project ? |
/test all |
I have added the VPC support in the existing test for the project. |
good, thanks /run-e2e -c 4.20 |
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
Test Results : (tid-550)
|
Setting up environment failed |
/run-e2e -h |
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
Setting up environment failed |
Test Results : (tid-553)
|
Setting up environment failed |
Test Results : (tid-556)
|
Test Results : (tid-557)
|
Test Results : (tid-560)
|
Test Results : (tid-561)
|
To be merged after: #415
Issue #, if available:
Fixes #314
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.