DiskOffering in CloudStackMachine CRD should be a pointer to CloudStackResourceDiskOffering #328
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @hrak. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
hrak
force-pushed
the
bug/disk_offering_ptr
branch
from
841dc2e to
02cfabc
Compare
k8s-ci-robot
added
size/L
|
While working on this PR i was surprised to find that API conversion code was not being generated anymore by the Makefile. I fixed that in this PR too + updated the webhooks to conform with requirements set in CAPI 0.4 (yes, 0.4) |
|
/lgtm |
|
/run-e2e -c 4.18 |
|
@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 25.45% 25.27% -0.18%
==========================================
Files 59 59
Lines 5555 5610 +55
==========================================
+ Hits 1414 1418 +4
- Misses 4002 4051 +49
- Partials 139 141 +2 ☔ View full report in Codecov by Sentry. |
|
Test Results : (tid-357) |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Hans Rakers <[email protected]>
Signed-off-by: Hans Rakers <[email protected]>
hrak
force-pushed
the
bug/disk_offering_ptr
branch
from
02cfabc to
3bc0c08
Compare
k8s-ci-robot
removed
the
needs-rebase
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle rotten |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/run-e2e -c 4.19 |
|
@vishesh92 a jenkins job has been kicked to run test with following paramaters:
|
|
@hrak: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Test Results : (tid-400) |
| api/%/zz_generated.conversion.go: bin/conversion-gen $(CONVERSION_GEN_INPUTS) | ||
| conversion-gen --go-header-file "./hack/boilerplate.go.txt" --input-dirs "./api/v1beta1" \ | ||
| --output-base "." --output-file-base="zz_generated.conversion" --skip-unsafe=true | ||
| generate-conversion: $(CONTROLLER_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3 |
There was a problem hiding this comment.
| generate-conversion: $(CONTROLLER_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3 | |
| generate-conversion: $(CONVERSION_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3 |
There was a problem hiding this comment.
@hrak capi-provider-cloudstack-presubmit-e2e-smoke-test is currently failing because it can't find conversion-gen.
| api/%/zz_generated.conversion.go: bin/conversion-gen $(CONVERSION_GEN_INPUTS) | ||
| conversion-gen --go-header-file "./hack/boilerplate.go.txt" --input-dirs "./api/v1beta1" \ | ||
| --output-base "." --output-file-base="zz_generated.conversion" --skip-unsafe=true | ||
| generate-conversion: $(CONTROLLER_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3 |
There was a problem hiding this comment.
| generate-conversion: $(CONTROLLER_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3 | |
| generate-conversion: $(CONVERSION_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@vishesh92 pl fix the minor issue post-merging this PR, thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hrak, vishesh92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hrak For some reason I am not able to resolve conflicts for this PR. If you have time, can you rebase this PR and resolve conflicts? Else I will have to create a duplicate PR. |
|
I have recreated this PR here: #359 |
Issue #, if available:
#326
Description of changes:
This is a breaking change in the (unreleased) v1beta3 API which changes the
DiskOfferingproperty ofCloudStackMachineto be a pointer toCloudStackResourceDiskOfferingReasoning is described in the above linked issue.
Testing performed:
make test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.