This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
See issue #1027. To support server-side dry-run, all admission webhooks must state that they do not have any side effects. Our version of controller-gen doesn't include the sideEffects marker so I added them as a kustomization patch. Tested: server-side dry-run fails on a pod creation in Kind 1.18 without this fix and passes with it. GKE doesn't have 1.18 yet so I couldn't test it there, but I also tested it on GKE 1.15 (the oldest currently supported version) to ensure that it had no ill effects, and all e2e tests work fine on both Kind 1.18 and GKE 1.15.
- Loading branch information