Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Commit

Permalink
Support server-side dry run
Browse files Browse the repository at this point in the history
See issue #1027. To support server-side dry-run, all admission webhooks
must state that they do not have any side effects. Our version of
controller-gen doesn't include the sideEffects marker so I added them as
a kustomization patch.

Tested: server-side dry-run fails on a pod creation in Kind 1.18 without
this fix and passes with it. GKE doesn't have 1.18 yet so I couldn't
test it there, but I also tested it on GKE 1.15 (the oldest currently
supported version) to ensure that it had no ill effects, and all e2e
tests work fine on both Kind 1.18 and GKE 1.15.
  • Loading branch information
adrianludwin committed Aug 26, 2020
1 parent 0aac07d commit ce98366
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions incubator/hnc/config/webhook/webhook_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,12 @@ metadata:
webhooks:
- name: objects.hnc.x-k8s.io
timeoutSeconds: 2
sideEffects: None
- name: subnamespaceanchors.hnc.x-k8s.io
sideEffects: None
- name: hierarchyconfigurations.hnc.x-k8s.io
sideEffects: None
- name: hncconfigurations.hnc.x-k8s.io
sideEffects: None
- name: namespaces.hnc.x-k8s.io
sideEffects: None

0 comments on commit ce98366

Please sign in to comment.