-
Notifications
You must be signed in to change notification settings - Fork 608
feat(alerts): New KubePdbNotEnoughHealthyPods alert #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hold, pending internal trial (~30 days). |
…, must contain at least one colon
FYI test deployment shows that I may need to revert part of #1013, which is causing an error with our internal pipeline:
The windows recording rules do not follow the correct name conventions. |
@@ -2,5 +2,4 @@ | |||
(import 'apps.libsonnet') + | |||
(import 'kube_scheduler.libsonnet') + | |||
(import 'node.libsonnet') + | |||
(import 'kubelet.libsonnet') + | |||
(import 'windows.libsonnet') | |||
(import 'kubelet.libsonnet') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes windows rules from the default build, see this comment where I was previously concerned about this change.
Fixes #1028