Split apiserver availability rule groups #1032
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the apiserver availability rules into two rule groups for async processing. This makes the rule groups less heavy without greatly impacting the data quality. * Fist group for shorter pre-aggregations. * Second group for longer SLI calculations. Some other improvements: * Eliminate the `code` rule split. Since these rules are sequential in one rule group it doesn't really improve performance. It also confuses the Prometheus Operator admission controller. Removing the regexp match also reduces the load on Prometheus. * Remove the `verb` regexp match so we also eliminate this regexp match. This also allows for all verbs to be included in this aggregation. Signed-off-by: SuperQ <[email protected]>
|
@SuperQ I noticed you marked the PR as draft, is there more work you're considering here? |
|
I had some issues trying to load the rendered output into our cluster, so I made it draft in case there was a mistake here. I'm still debugging why it's not loading for us. |
|
Feel free to post the error here in case you'd like a second set of eyes! 😄 |
|
This PR has been automatically marked as stale because it has not The next time this stale check runs, the stale label will be Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the apiserver availability rules into two rule groups for async processing. This makes the rule groups less heavy without greatly impacting the data quality.
Some other improvements:
coderule split. Since these rules are sequential in one rule group it doesn't really improve performance. It also confuses the Prometheus Operator admission controller. Removing the regexp match also reduces the load on Prometheus.verbregexp match so we also eliminate this regexp match. This also allows for all verbs to be included in this aggregation.