Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.32 images #3568

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 26, 2025

What this PR does / why we need it:
Update images for Kubernetes 1.32 support

Which issue(s) this PR fixes:

xref #3567

What type of PR is this?
/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Images updates:
* Calico / Canal v3.29.2
* Cilium: v1.17.1
* DNS node cache: 1.25.0
* cluster-autoscaler: v1.30.3
* cluster-autoscaler: v1.31.1
* cluster-autoscaler: v1.32.0
* AWS CCM: v1.29.8
* AWS CCM: v1.30.7
* AWS CCM: v1.31.5
* AWS CCM: v1.32.1
* Azure CCM: v1.30.8
* Azure CCM: v1.31.2
* Azure CCM: v1.32.1
* Azure Disk CSI: v1.32.0
* Azure File CSI: v1.32.0
* Digitalocean CCM: v0.1.59
* Hetzner CCM: v1.23.0
* Hetzner CSI: v2.13.0
* OpenstackCCM: v1.32.0
* NutanixCCM: v0.5.0
* Restic: v0.17.3
* CSI external snapshot: v8.2.1

ACTION REQUIRED: canal-vxlan addon is deleted as it never worked properly.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 26, 2025
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kron4eg. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 26, 2025
@kron4eg kron4eg force-pushed the kubernetes_1.32_images branch 3 times, most recently from dd18033 to fb84af9 Compare March 4, 2025 09:02
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2025
@kron4eg kron4eg force-pushed the kubernetes_1.32_images branch from 8c0f513 to 7acc00e Compare March 6, 2025 11:25
@kron4eg kron4eg marked this pull request as ready for review March 6, 2025 13:47
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2025
@kron4eg kron4eg requested a review from xmudrii March 6, 2025 13:54
@kron4eg
Copy link
Member Author

kron4eg commented Mar 6, 2025

/retest

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 7, 2025
@kron4eg kron4eg marked this pull request as draft March 7, 2025 11:49
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
@kron4eg
Copy link
Member Author

kron4eg commented Mar 11, 2025

/test pull-kubeone-e2e-aws-default-install-containerd-external-v1.32

@kron4eg kron4eg marked this pull request as ready for review March 11, 2025 14:23
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
@kron4eg kron4eg requested a review from xmudrii March 11, 2025 15:17
kron4eg added 22 commits March 14, 2025 10:57
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg force-pushed the kubernetes_1.32_images branch from f06853a to 66998f1 Compare March 14, 2025 08:57
@kron4eg
Copy link
Member Author

kron4eg commented Mar 17, 2025

/cc @ahmedwaleedmalik

Comment on lines +3 to +7
kind: Namespace
metadata:
labels:
app.kubernetes.io/part-of: cilium
name: kube-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want the Cilium addon to manage the kube-system namespace? That sounds potentially disastrous 😅

Comment on lines +906 to +923
apiVersion: v1
kind: Service
metadata:
labels:
app.kubernetes.io/name: hubble-peer
app.kubernetes.io/part-of: cilium
k8s-app: cilium
name: hubble-peer
namespace: kube-system
spec:
internalTrafficPolicy: Local
ports:
- name: peer-service
port: 80
protocol: TCP
targetPort: 4244
selector:
k8s-app: cilium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in hubble.yaml

name: socket-dir
- args:
- -csi-address=$(ADDRESS)
- -leader-election
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is -leader-election correct here, shouldn't it be --leader-election?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 IDK, it's the helm chart that rendered like this. I suppose this is as expected.

@@ -57,7 +57,7 @@ import (

const (
labelControlPlaneNode = "node-role.kubernetes.io/control-plane"
prowjobImage = "quay.io/kubermatic/build:go-1.23-node-20-6"
prowjobImage = "quay.io/kubermatic/build:go-1.24-node-20-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go update requires a bit more work, leaving a comment so we don't forget about that (there should probably be an issue for it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants