-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes 1.32 images #3568
base: main
Are you sure you want to change the base?
Kubernetes 1.32 images #3568
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dd18033
to
fb84af9
Compare
8c0f513
to
7acc00e
Compare
/retest |
/test pull-kubeone-e2e-aws-default-install-containerd-external-v1.32 |
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
f06853a
to
66998f1
Compare
kind: Namespace | ||
metadata: | ||
labels: | ||
app.kubernetes.io/part-of: cilium | ||
name: kube-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want the Cilium addon to manage the kube-system
namespace? That sounds potentially disastrous 😅
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
labels: | ||
app.kubernetes.io/name: hubble-peer | ||
app.kubernetes.io/part-of: cilium | ||
k8s-app: cilium | ||
name: hubble-peer | ||
namespace: kube-system | ||
spec: | ||
internalTrafficPolicy: Local | ||
ports: | ||
- name: peer-service | ||
port: 80 | ||
protocol: TCP | ||
targetPort: 4244 | ||
selector: | ||
k8s-app: cilium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in hubble.yaml
name: socket-dir | ||
- args: | ||
- -csi-address=$(ADDRESS) | ||
- -leader-election |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is -leader-election
correct here, shouldn't it be --leader-election
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 IDK, it's the helm chart that rendered like this. I suppose this is as expected.
@@ -57,7 +57,7 @@ import ( | |||
|
|||
const ( | |||
labelControlPlaneNode = "node-role.kubernetes.io/control-plane" | |||
prowjobImage = "quay.io/kubermatic/build:go-1.23-node-20-6" | |||
prowjobImage = "quay.io/kubermatic/build:go-1.24-node-20-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go update requires a bit more work, leaving a comment so we don't forget about that (there should probably be an issue for it).
What this PR does / why we need it:
Update images for Kubernetes 1.32 support
Which issue(s) this PR fixes:
xref #3567
What type of PR is this?
/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: