Fix APT/RPM PGP key expiration issue for old kubernetes versiosn #3524
Conversation
kubermatic-bot
added
docs/none
|
/assign |
pkg/scripts/os_amzn.go
Outdated
| @@ -44,13 +44,14 @@ echo -n "${yum_proxy}" >> /tmp/yum.conf | |||
| sudo mv /tmp/yum.conf /etc/yum.conf | |||
|
|
|||
| {{ if .CONFIGURE_REPOSITORIES }} | |||
| LATEST_STABLE=$(curl -s https://cdn.dl.k8s.io/release/stable.txt | sed 's/\.[0-9]*$//') | |||
There was a problem hiding this comment.
Let's not use cdn.dl.k8s.io directly, but instead use just dl.k8s.io, to be on the safe side.
kubermatic-bot
added
size/M
|
LGTM label has been added. Git tree hash: 5a4f622b9db564a32bb14ddf6febc5c87b9a15af
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/release-note-edit |
|
/cherrypick release/v1.8 |
|
/cherrypick release/v1.9 |
|
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xmudrii: new pull request created: #3525 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xmudrii: new pull request created: #3526 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR addresses the issue of expired GPG keys for Kubernetes apt/rpm repositories by dynamically fetching the GPG key corresponding to the latest stable Kubernetes version.
According to this comment
https://github.com/kubernetes/release/issues/3818#issuecomment-2455160940We can use the gpg key from the latest kubernetes repository.
Which issue(s) this PR fixes:
Fixes #3460
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: