Skip to content

Commit

Permalink
test/e2e: Disable ClusterAutoscaler scaling down testing nodes
Browse files Browse the repository at this point in the history
Update the clusterautoscaler.yaml YAML manifest that is used to create
a `ClusterAutoscaler` instance in our testing clusters, and disable node
scaling down mechanisms.

We're seeing more and more e2e flakes centered around the
reporting-operator being scaled down at inopportune times, namely when
attempting to get Report results. In the context of our e2e suite, these
additional nodes should be swept up when uninstalling the OCP cluster.

Note: Another way to ensure we're not evicting the reporting-operator
container from a particular node is to add the following label to that
deployment definition:

```
metadata:
  labels:
    cluster-autoscaler.kubernetes.io/safe-to-evict=false
```

Adding this label doesn't make much sense given the reporting-operator
container isn't a workload that we typically care about being evicted,
but in the context of the e2e suite and reducing e2e flakes adding this
label may make sense in the future. Other alternatives include creating
a PodDisruptionBudget resource for the reporting-operator workloads, but
this is an extreme case and like that eviction label, doesn't make much
sense for a non-important workload.
  • Loading branch information
timflannagan committed Feb 17, 2021
1 parent a28a1df commit 8328915
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions test/e2e/manifests/machines/clusterautoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,4 @@ spec:
max: 256
min: 16
scaleDown:
delayAfterAdd: 2m
delayAfterDelete: 2m
delayAfterFailure: 30s
enabled: true
unneededTime: 60s
enabled: false

0 comments on commit 8328915

Please sign in to comment.