Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve logging for create-advisory task #820

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

johnbieren
Copy link
Collaborator

This commit modifies the create-advisory task to print out the internalRequest taskrun and pipelinerun name, as well as saving the internal failures to a STDERR file that is tailed into the task result. This should better expose issues to users.

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Feb 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@johnbieren johnbieren force-pushed the advlogging branch 2 times, most recently from 207a93e to defcd4c Compare February 19, 2025 15:02
@johnbieren johnbieren marked this pull request as ready for review February 19, 2025 15:04
@johnbieren johnbieren requested a review from a team as a code owner February 19, 2025 15:04
@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

/retest
failed to provision cluster

@johnbieren johnbieren force-pushed the advlogging branch 3 times, most recently from 6726ce5 to 71acdec Compare February 19, 2025 20:30
@johnbieren
Copy link
Collaborator Author

/retest
failed to provision cluster

This commit modifies the create-advisory task to print out the
internalRequest taskrun and pipelinerun name, as well as saving the
internal failures to a STDERR file that is tailed into the task result.
This should better expose issues to users.

Signed-off-by: Johnny Bieren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant