Add process-level parallelism to uvicorn.run
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess-level parallelism with uvicorn
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #103 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 34 34
Lines 1465 1465
=======================================
Hits 1420 1420
Misses 45 45 ☔ View full report in Codecov by Sentry. |
ly-kolena
reviewed
Oct 4, 2024
| @@ -53,3 +53,37 @@ def write() -> None: | |||
|
|
|||
| with get_database_connection(database_file) as conn: | |||
| assert conn.cursor().execute("SELECT COUNT(*) FROM test").fetchone() == (1 + n_writers,) | |||
|
|
|||
|
|
|||
| def multiproc_read_write(database_file: Path, n_readers: int) -> list[list[tuple[str]]]: | |||
There was a problem hiding this comment.
side note: EFS seems to be build around NFS, and there's mention of intricacies in NFS file locking from faq. I have not looked further yet.
There was a problem hiding this comment.
Good flag, I'll see if this causes any issues. This PR doesn't fix the underlying slowness problem on Cloud, just mitigates it — still some digging to do to find the culprit for the slowdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable multiple worker processes when running the app in normal mode (not
--dev) and add test verifying that database reads and writes behave as expected under these conditions.