feat: Add support for tauri configuration files #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for knope ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dbanty
reviewed
Mar 22, 2025
Comment on lines
+40
to
+43
| TauriConf(TauriConfJson), | ||
| TauriMacosConf(TauriConfJson), | ||
| TauriWindowsConf(TauriConfJson), | ||
| TauriLinuxConf(TauriConfJson), |
There was a problem hiding this comment.
I see what you mean about the 1-1 file type to path being problematic. We should definitely decouple those and let there be multiple file names per type. I'll take a stab at that
Comment on lines
+168
to
+169
|
|
||
| `dependency` isn't supported yet. |
There was a problem hiding this comment.
Suggested change
| `dependency` isn't supported yet. |
I don't think there is anything dependency-like to version in here in the future.
| #[cfg_attr( | ||
| feature = "miette", | ||
| diagnostic( | ||
| code(package_json::deserialize), |
There was a problem hiding this comment.
Suggested change
| code(package_json::deserialize), | |
| code(tauri_conf_json::deserialize), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Tauri configuration files support for Knope
Closes #1375