Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsonata Event transform e2e tests #8499

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Jsonata Event transform e2e tests #8499

merged 5 commits into from
Feb 24, 2025

Conversation

pierDipi
Copy link
Member

Waiting for knative-extensions/eventing-integrations#72 to be merged and built

@pierDipi
E2E tests
f65b2ec 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi
EventTransform Jsonata e2e tests
4de8574 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@knative-prow knative-prow bot requested review from Cali0707 and mgencur February 24, 2025 12:56
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2025
@pierDipi pierDipi force-pushed the event-transform-e2e-tests branch from f60a678 to 3e77fec Compare February 24, 2025 13:01
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (c651616) to head (3e77fec).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8499      +/-   ##
==========================================
+ Coverage   62.62%   62.81%   +0.18%     
==========================================
  Files         396      396              
  Lines       24231    24231              
==========================================
+ Hits        15175    15221      +46     
+ Misses       8247     8201      -46     
  Partials      809      809

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@pierDipi pierDipi marked this pull request as ready for review February 24, 2025 13:51
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
matzew
matzew approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/test unit-tests

2 similar comments
@pierDipi
Copy link
Member Author

/test unit-tests

@pierDipi
Copy link
Member Author

/test unit-tests

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/retest

@pierDipi
Update JSONata transformations
0e77d7d 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi force-pushed the event-transform-e2e-tests branch from a6aaf16 to 0e77d7d Compare February 24, 2025 15:25
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@pierDipi
Copy link
Member Author

/test unit-tests

1 similar comment
@pierDipi
Copy link
Member Author

/test unit-tests

@pierDipi pierDipi requested a review from matzew February 24, 2025 16:17
@pierDipi
Copy link
Member Author

Sorry @matzew, I picked the wrong image SHA earlier, now it works

@pierDipi
Copy link
Member Author

/test unit-tests

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@knative-prow knative-prow bot merged commit ae049c8 into knative:main Feb 24, 2025
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@mgencur mgencur Awaiting requested review from mgencur

@aslom aslom Awaiting requested review from aslom

@evankanderson evankanderson Awaiting requested review from evankanderson

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @matzew