Generic code for Certificates #8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8489 +/- ##
=======================================
Coverage 62.62% 62.62%
=======================================
Files 396 396
Lines 24231 24231
=======================================
Hits 15175 15175
Misses 8247 8247
Partials 809 809 ☔ View full report in Codecov by Sentry. |
knative-prow-robot
added
the
needs-rebase
knative-prow-robot
removed
the
needs-rebase
knative-prow
bot
added
size/S
matzew
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
matzew
commented
Feb 20, 2025
| ) | ||
|
|
||
| func CertificateName(sinkName string) string { | ||
| return kmeta.ChildName(sinkName, "-server-tls") | ||
| } | ||
|
|
||
| func MakeCertificate(sink *v1alpha1.IntegrationSink) *cmv1.Certificate { | ||
| func MakeCertificate(sink kmeta.OwnerRefableAccessor, name string) *cmv1.Certificate { |
There was a problem hiding this comment.
@pierDipi I found this as a way to pass in generic types
|
Should we move this to (and perhaps adding a simple test) |
|
/test unit-tests |
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow
bot
added
size/L
|
/test unit-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest |
|
/test reconciler-tests |
|
/test unit-tests |
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Feb 25, 2025
Make Certifacte factory more generic Signed-off-by: Matthias Wessendorf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs