-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntegrationSink prefactors #8486
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
var ( | ||
_ runtime.Object = (*IntegrationSink)(nil) | ||
_ kmeta.OwnerRefable = (*IntegrationSink)(nil) | ||
_ apis.Validatable = (*IntegrationSink)(nil) | ||
_ apis.Defaultable = (*IntegrationSink)(nil) | ||
_ apis.HasSpec = (*IntegrationSink)(nil) | ||
_ duckv1.KRShaped = (*IntegrationSink)(nil) | ||
_ apis.Convertible = (*JobSink)(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy / pasta 🍝
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8486 +/- ##
==========================================
- Coverage 62.77% 62.65% -0.13%
==========================================
Files 395 397 +2
Lines 24108 24241 +133
==========================================
+ Hits 15135 15188 +53
- Misses 8166 8245 +79
- Partials 807 808 +1 ☔ View full report in Codecov by Sentry. |
/test unit-tests |
4 similar comments
|
/test unit-tests |
/test unit-tests |
/test unit-tests |
Little refactors on IntegrationSink Signed-off-by: Matthias Wessendorf <[email protected]>
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs