Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegrationSink prefactors #8486

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 19, 2025

Fixes #

Proposed Changes

  • before moving code, aligning some issues and make code different

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2025
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
Copy link

knative-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

var (
_ runtime.Object = (*IntegrationSink)(nil)
_ kmeta.OwnerRefable = (*IntegrationSink)(nil)
_ apis.Validatable = (*IntegrationSink)(nil)
_ apis.Defaultable = (*IntegrationSink)(nil)
_ apis.HasSpec = (*IntegrationSink)(nil)
_ duckv1.KRShaped = (*IntegrationSink)(nil)
_ apis.Convertible = (*JobSink)(nil)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy / pasta 🍝

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (9a7c6d5) to head (ec6db02).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...conciler/integration/sink/resources/certificate.go 0.00% 7 Missing ⚠️
pkg/reconciler/integration/sink/integrationsink.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8486      +/-   ##
==========================================
- Coverage   62.77%   62.65%   -0.13%     
==========================================
  Files         395      397       +2     
  Lines       24108    24241     +133     
==========================================
+ Hits        15135    15188      +53     
- Misses       8166     8245      +79     
- Partials      807      808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Member Author

matzew commented Feb 20, 2025

/test unit-tests

4 similar comments
@pierDipi
Copy link
Member

/test unit-tests

@pierDipi
Copy link
Member

/test unit-tests

@matzew
Copy link
Member Author

matzew commented Feb 20, 2025

/test unit-tests

@matzew
Copy link
Member Author

matzew commented Feb 20, 2025

/test unit-tests

@knative-prow knative-prow bot merged commit 51637df into knative:main Feb 20, 2025
30 of 36 checks passed
matzew added a commit to matzew/eventing that referenced this pull request Feb 25, 2025
Little refactors on IntegrationSink

Signed-off-by: Matthias Wessendorf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants