Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventTransform: Support transforming response from Sink #8469

Merged
merged 1 commit into from
Feb 17, 2025
Merged

EventTransform: Support transforming response from Sink #8469

merged 1 commit into from
Feb 17, 2025

Conversation

pierDipi
Copy link
Member

This allows:

  • propagating the response from Sink
  • discarding the response from Sink
  • transforming the response from Sink

Fixes #

EventTransform: Support transforming response from Sink

Docs

@pierDipi
EventTransform: Support transforming response from Sink
929bbd0 
This allows:
- propagating the response from Sink
- discarding the response from Sink
- transforming the response from Sink

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from aslom and Cali0707 February 17, 2025 11:57
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.28571% with 48 lines in your changes missing coverage. Please review.

Project coverage is 62.76%. Comparing base (75195a5) to head (929bbd0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/eventtransform/resources_jsonata.go 0.00% 34 Missing ⚠️
...pis/eventing/v1alpha1/eventtransform_validation.go 80.28% 11 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8469      +/-   ##
==========================================
+ Coverage   62.66%   62.76%   +0.09%     
==========================================
  Files         395      395              
  Lines       24018    24108      +90     
==========================================
+ Hits        15052    15132      +80     
- Misses       8162     8168       +6     
- Partials      804      808       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew reviewed Feb 17, 2025
View reviewed changes
pkg/reconciler/eventtransform/resources_jsonata.go
JsonataExpressionDataKey = "jsonata-expression"
JsonataReplyExpressionDataKey = "jsonata-expression-reply"

JsonataExpressionPath = "/etc/jsonata"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ata? or data?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. jsonata

matzew
matzew approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Feb 17, 2025

/retest

@matzew matzew closed this Feb 17, 2025
@matzew matzew reopened this Feb 17, 2025
@matzew
Copy link
Member

matzew commented Feb 17, 2025

wrong button 😅

@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

/test unit-tests

@knative-prow knative-prow bot merged commit cee6e8c into knative:main Feb 17, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aslom aslom Awaiting requested review from aslom

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @matzew