Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding missing sinks and sources to schema file #8460

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 13, 2025

Fixes #

Proposed Changes

  • as per title

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2025
@knative-prow knative-prow bot requested review from Cali0707 and pierDipi February 13, 2025 07:37
@matzew
Copy link
Member Author

matzew commented Feb 13, 2025

/assign @pierDipi
nit: just adding missing artifacts

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.99%. Comparing base (779992f) to head (ee028c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/schema/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8460      +/-   ##
==========================================
- Coverage   63.02%   62.99%   -0.03%     
==========================================
  Files         394      394              
  Lines       23882    23887       +5     
==========================================
- Hits        15051    15048       -3     
- Misses       8028     8035       +7     
- Partials      803      804       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
Copy link

knative-prow bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 36d681e into knative:main Feb 13, 2025
35 of 36 checks passed
matzew added a commit to matzew/eventing that referenced this pull request Feb 25, 2025
💄 Adding missing sinks and sources to schema file

Signed-off-by: Matthias Wessendorf <[email protected]>
matzew added a commit to matzew/eventing that referenced this pull request Feb 25, 2025
💄 Adding missing sinks and sources to schema file

Signed-off-by: Matthias Wessendorf <[email protected]>
matzew added a commit to matzew/eventing that referenced this pull request Feb 25, 2025
💄 Adding missing sinks and sources to schema file

Signed-off-by: Matthias Wessendorf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants