-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard reserved access with lock and create vpods in tests #8457
Guard reserved access with lock and create vpods in tests #8457
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8457 +/- ##
==========================================
- Coverage 62.83% 62.80% -0.03%
==========================================
Files 396 396
Lines 24233 24233
==========================================
- Hits 15226 15220 -6
- Misses 8199 8203 +4
- Partials 808 810 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-tests |
1 similar comment
/test unit-tests |
there seems to be a test issue |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
c4206df
to
d355ccf
Compare
/cherry-pick release-1.17 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
@pierDipi: new pull request created: #8504 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.16 |
@pierDipi: new pull request created: #8505 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix data race in tests