-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reordered logging levels, added alert logger #105
base: master
Are you sure you want to change the base?
Conversation
What's inside: 1. Added the "alert" logger, it is intended for messages that must be seen, for example, to manually catch an error. 2. The "debug" level now has a low priority and is not so visually highlighted: it is intended for unimportant messages that are usually not needed, but which would be useful to have in the system if something goes wrong. 3. In case someone wants to inherit from the "Signale" class, the "scope" method now correctly creates an instance of the current class with which it was created. 4. Added the ability to set your own log levels, without having to inherit to override the "_logLevels" getter. Fixes klaudiosinani#96
I find that move kind of harsh. I agree with you on the content. It seems that this repo is going on the dark path of inactivity, and this is really frustrating since there is some works pending. But I don't think this is the good solution. If everybody starts to fork and release their own version of the application, it will be a mess. And this is an heavy anti-pattern of Open Source. We need an issue to discuss about the inactivity and the right solutions to deal with it. On an other point, your PR is not mergeable :
I'm sad to see this selfishness in the open source world. |
Added two fixes to PR:
|
What's inside:
Fixes #96