Add sendButton command to send remote button presses
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tenzer
commented
Dec 10, 2023
| parser.print_help() | ||
| sys.exit(1) | ||
| except Exception: | ||
| if args.command not in {"sendButton"}: |
There was a problem hiding this comment.
I'm not quite satisfied with this hack to add support for an extra command that isn't on the LGTVRemote class.
I wonder if we can do something to make exposing commands to the CLI cleaner, but that might be for future work.
This makes it possible to send a sequence of button presses (among the current options) to the TV which can help automate actions that can't otherwise be achieved with the normal API.
Closed
|
I've added you as a contributor to the project, I think you probably need a bit of freedom in this now as you've taken up a fair bit of my mornings clearing PRs. Not a bad thing, but #levelup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to send a sequence of button presses (among the current options) to the TV which can help automate actions that can't otherwise be achieved with the normal API.
https://github.com/JPersson77/LGTVCompanion/blob/master/Common/lg_api_buttons.h has a list of more button presses that appear to be possible options. We could potentially look at adding them later.
Fixes #66.