This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
React and ReactMotion should be peerDependencies #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we might bundle two distinct versions of React due to the way NPM install dependencies.
|
I guess the idea is that any "big enough" library should be turned into a |
|
React was introduced as a dependency recently at https://github.com/klarna/ui/pull/139/files |
xaviervia
approved these changes
Oct 31, 2016
|
Yes, I removed react as a peerDependency so if one uses Preact he doesn't even need to install it... but if you know this is really needed, ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we might bundle two distinct versions of React due to the way npm installs dependencies.