Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS class markdown-alert instead of alert #524

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

digitalmoksha
Copy link
Collaborator

Using the CSS classes alert and alert-warning can clash with other CSS frameworks, such as Bootstrap

GitHub uses markdown-alert in their output - let's align with that in order to avoid needless class collisions.

Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-c350aa0 319.6 ± 1.5 317.3 323.7 2.93 ± 0.04
./bench.sh ./comrak-main 324.4 ± 16.4 317.2 399.4 2.97 ± 0.15
./bench.sh ./pulldown-cmark 109.1 ± 1.2 107.5 111.7 1.00
./bench.sh ./cmark-gfm 115.2 ± 0.9 112.9 117.2 1.06 ± 0.01
./bench.sh ./markdown-it 476.0 ± 2.2 470.8 481.3 4.36 ± 0.05

Run on Wed Jan 22 23:31:04 UTC 2025

@digitalmoksha digitalmoksha force-pushed the bw-switch-to-markdown-alert branch from b2a9e56 to 12ec9b0 Compare January 22, 2025 23:31
@digitalmoksha
Copy link
Collaborator Author

@kivikakk I think I'm catching this early enough not to be a problem. In the back of my mind I thought alert was too generic, and I think it really is.

@digitalmoksha digitalmoksha force-pushed the bw-switch-to-markdown-alert branch from 12ec9b0 to 8d30848 Compare January 22, 2025 23:34
Copy link
Owner

@kivikakk kivikakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepyep, makes sense! :)

@digitalmoksha digitalmoksha merged commit 1408885 into main Jan 23, 2025
38 checks passed
@digitalmoksha digitalmoksha deleted the bw-switch-to-markdown-alert branch January 23, 2025 02:43
@digitalmoksha
Copy link
Collaborator Author

Really sorry to ask, but if you have time for another release…

@kivikakk
Copy link
Owner

On it!

@kivikakk
Copy link
Owner

Done! crates.io, GitHub release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants