Upgrade to NES2.0 header #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/header.asm
Outdated
| ; https://github.com/bbbradsmith/NES-ca65-example | ||
|
|
||
| .segment "HEADER" | ||
|
|
||
| .include "constants.asm" ; for INES_HEADER | ||
|
|
||
| INES_MIRROR = 0 ; 0 = horizontal mirroring, 1 = vertical mirroring (ignored in MMC1) | ||
| INES_SRAM = 1 ; 1 = battery backed SRAM at $6000-7FFF | ||
| INES_SRAM = SAVE_HIGHSCORES ; 1 = battery backed SRAM at $6000-7FFF |
There was a problem hiding this comment.
we should probably add a HAS_SRAM flag for clarity
There was a problem hiding this comment.
Should that flag be a new addition, or should it replace an existing flag? I think replacing SAVE_HIGHSCORES would make the most sense here. The header should ideally be a set-and-forget kind of thing in my opinion.
There was a problem hiding this comment.
I think it should be an additional flag so the saving highscores can be disabled separately if needed.
In a newer version we might decide to remove or replace it and leaving the name makes it easier to remove.
There was a problem hiding this comment.
I added the HAS_SRAM flag but disabling it is currently lumped with the -s build flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the header from iNES to the forwards-compatible NES2.0 in order to better describe the cart specification:
SAVE_HIGHSCORESflag in the header (previously, SRAM was always enabled in the header)-ibuild flag for legacy iNES header supportDocument workaround for NES2.0 header issues on PowerPakWith the BPS patch now being header-agnostic, this should help with adapting to the transition from iNES to NES2.0. (e.g. as seen in #19)