Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmented Control: Implement ControlValueAccessor to support Angular forms #3873

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

lydemann
Copy link
Collaborator

@lydemann lydemann commented Mar 19, 2025

Which issue does this PR close?

This PR closes # (insert issue number here)
#3791

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@lydemann lydemann changed the title Feature/segment control vca Implement ControlValueAccessor for Segment control Mar 19, 2025
@github-actions github-actions bot temporarily deployed to pr-segment-control-vca March 19, 2025 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pr-segment-control-vca March 19, 2025 12:33 Inactive
@RasmusKjeldgaard RasmusKjeldgaard changed the title Implement ControlValueAccessor for Segment control Segment Control: Implement ControlValueAccessor to support Angular forms Mar 19, 2025
@RasmusKjeldgaard RasmusKjeldgaard changed the title Segment Control: Implement ControlValueAccessor to support Angular forms Segmented Control: Implement ControlValueAccessor to support Angular forms Mar 19, 2025
@RasmusKjeldgaard RasmusKjeldgaard added the feature Add this PR to the changelog as a feature label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants