Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Extended toast description in cookbook with example in Iframe #3845

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Fuzzy3
Copy link
Collaborator

@Fuzzy3 Fuzzy3 commented Mar 4, 2025

Which issue does this PR close?

This PR closes #3841

What is the new behavior?

Better description of toast usages. Toast example in Iframe.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@Fuzzy3 Fuzzy3 requested a review from jkaltoft as a code owner March 4, 2025 07:51
@Fuzzy3 Fuzzy3 linked an issue Mar 4, 2025 that may be closed by this pull request
9 tasks
@github-actions github-actions bot temporarily deployed to pr-3841-bug-cant-scroll-view-when-showing-toast March 4, 2025 09:43 Inactive
@github-actions github-actions bot temporarily deployed to pr-3841-bug-cant-scroll-view-when-showing-toast March 4, 2025 15:39 Inactive
@github-actions github-actions bot temporarily deployed to pr-3841-bug-cant-scroll-view-when-showing-toast March 12, 2025 09:23 Inactive
Comment on lines +1 to +3
<kirby-app>
<kirby-router-outlet></kirby-router-outlet>
</kirby-app>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great to align these examples with how we do for the modal, with a full-size viewmode of the cookbook-iphone that can be toggled to show a device view.

image

@github-actions github-actions bot temporarily deployed to pr-3841-bug-cant-scroll-view-when-showing-toast March 12, 2025 13:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Can't scroll view when showing toast (only in cookbook)
2 participants