Form field: announce error text when nested interactive is focussed #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage-not-announced
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
Comment on lines
-156
to
-158
| // TODO: remove "!this.inputElement.readOnly" when ionic has fixed input click issue | ||
| // https://github.com/ionic-team/ionic-framework/issues/22740 |
There was a problem hiding this comment.
Checking for the readOnly property complicates the logic a bit as the nestedInteractiveElement can now also be a radio-group that does not have that property.
The linked issue is fixed by Ionic, so instead I tried to be a good scout and removed the logic.
I tested on a device, and inputs with readOnly cannot be focussed, while inputs without can be focussed with a single click as expected.
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
RasmusKjeldgaard
changed the title
RasmusKjeldgaard
changed the title
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
Fuzzy3
requested changes
Jan 20, 2025
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
github-actions
bot
temporarily deployed
to
pr-3680-error-message-not-announced
Fuzzy3
previously approved these changes
Feb 5, 2025
| @@ -0,0 +1,6 @@ | |||
| import { EventEmitter } from '@angular/core'; | |||
|
|
|||
| export interface FormFieldControl { | |||
There was a problem hiding this comment.
Now that I'm looking at the hasError logic, I noticed its all the same lines of code. Maybe we should have a base FormFieldControl that all the other components extend?
There was a problem hiding this comment.
Good idea, would prefer if we add it in another PR for just that 🚀
…sage-not-announced
Fuzzy3
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3680
What is the new behavior?
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.