Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Can't scroll view when showing toast (only in cookbook) #3841

Open
1 of 9 tasks
Fuzzy3 opened this issue Mar 3, 2025 · 1 comment · May be fixed by #3845
Open
1 of 9 tasks

[BUG] - Can't scroll view when showing toast (only in cookbook) #3841

Fuzzy3 opened this issue Mar 3, 2025 · 1 comment · May be fixed by #3845
Assignees
Labels

Comments

@Fuzzy3
Copy link
Collaborator

Fuzzy3 commented Mar 3, 2025

Describe the bug

While a toast is being shown the view is locked for scrolling.

Describe how to reproduce the bug

  1. Open the toast section in the cookbook: https://cookbook.kirby.design/#/home/showcase/toast
  2. Click on any of the show toast buttons
  3. While the toast is being shown, the view can't be scrolled

Which Kirby version was used?

v10.3.0
It works in v10.2.1

What was the expected behavior?

Scrolling should be allowed while a toast is being shown

Add any screenshots

Please complete the following information:

  • OS: [e.g. Windows, MacOS, iOS]
  • Browser [e.g. Chrome, Safari]
  • Browser version [e.g. 22]

Are there any additional context?

Checked out the commit before and after the Angular 19 upgrade, and it seems to be that upgrade that broke the toasts.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@Fuzzy3 Fuzzy3 added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild 👶🏻 New For new issues before prioritisation and refinement labels Mar 3, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Mar 3, 2025
@Fuzzy3 Fuzzy3 moved this from 💌 Inbox to 🚀 In Progress in Kirby Mar 3, 2025
@Fuzzy3
Copy link
Collaborator Author

Fuzzy3 commented Mar 3, 2025

Turns out this is only a problem in the cookbook because we removed the wrapping kirby-app, which contains an ion-app (when we upgraded to angular 19 #3758)

Image

Ion-app is used as reference for where to put an overlay (overlay = modal, actionsheet, alert, toast, etc.) in ionic, see line 126 in https://github.com/ionic-team/ionic-framework/blob/main/core/src/utils/overlays.ts.

So when we try to display a toast, we look for an ion-app but no such element is found in the cookbook, then it places the toast in the body instead, which then accidentally covers the whole screen and makes it unscrollable.

@Fuzzy3 Fuzzy3 changed the title [BUG] - Can't scroll view when showing toast [BUG] - Can't scroll view when showing toast (only in cookbook) Mar 3, 2025
@Fuzzy3 Fuzzy3 linked a pull request Mar 4, 2025 that will close this issue
8 tasks
@Fuzzy3 Fuzzy3 moved this from 🚀 In Progress to 🔎 Review Pending in Kirby Mar 4, 2025
@Fuzzy3 Fuzzy3 assigned Fuzzy3 and RasmusKjeldgaard and unassigned Fuzzy3 Mar 4, 2025
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 Review In Progress
Development

Successfully merging a pull request may close this issue.

2 participants