Add S3 backend. #29
Open
Add S3 backend. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerize puppet-forge-server Add options as environmentals
|
Nice!!! Let me have a closer look... |
|
Sorry for the delay, I was a bit absorbed by other errands. First of all thanks for the great input! I was wondering whether you could divide this PR into several ones, for better visibility. For example docker related changes, option parsing and s3 backend. Maybe even a fourth one for minor changes like line 33 in lib/puppet_forge_server/api/v3/releases.rb, as there some complications to that change. It would be great if you could include a few unit tests stressing new methods and maybe even old ones if there are behavioural changes. Minor improvements to reduce code duplication in S3 and for example Directory classes could be made as well, but that's a minor thing and I could take care of it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an S3 backend.
I Dockerized the service and added the ability of using the options with environmentals to make it easier to use in docker.