-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for multiple business setup documented #347
base: main
Are you sure you want to change the base?
feat: support for multiple business setup documented #347
Conversation
WalkthroughThe changes update the Ruby SDK documentation file by adding commented-out lines in several method signatures. These comments indicate the default values drawn from the configuration object ( Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/content/docs/developer-tools/sdks/backend/ruby-sdk.mdx (1)
123-127
: Clarify Default Value Documentation forclient_credentials_access
The commented-out default values (e.g.
# client_id: # default to @config.client_id
) clearly indicate how the method may fall back to configuration values. However, since the example uses explicit ENV values forclient_id
andclient_secret
while also showing the configuration fallback as comments, consider adding a brief note (or aligning the comments) to explain when one should override the defaults versus using the provided ENV variables.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/developer-tools/sdks/backend/ruby-sdk.mdx
(4 hunks)
🔇 Additional comments (4)
src/content/docs/developer-tools/sdks/backend/ruby-sdk.mdx (4)
136-142
: Consistent Inline Documentation forauth_url
The update now documents optional parameters with inline commented-out defaults (such as
# client_id: # default to @config.client_id
). This improves clarity. Ensure that the order of these commented parameters matches the actual signature of the underlying method to prevent any potential confusion for developers.
178-185
: Descriptive Defaults forfetch_tokens
MethodThe inline comments detailing default behavior for parameters like
client_id
,client_secret
,domain
,code_verifier
, andredirect_uri
significantly enhance the documentation. This makes it clear what values are assumed if not explicitly provided.
514-521
: Clear Documentation fortoken_expired?
DefaultsThe commented parameters (including
# audience: # default to "#{@config.domain}/api"
) offer readers a good understanding of the default configuration used intoken_expired?
. The consistency with the other methods is a plus.
521-527
: Inline Default Values forrefresh_token
DocumentationThe default values for
client_id
,client_secret
,audience
, anddomain
are clearly documented through inline comments. This update provides improved clarity on how the method behaves when optional parameters are omitted.
Description (required)
This documents the updated Ruby SDK which enables the support for multiple businesses
Related issues & labels (optional)
Summary by CodeRabbit