-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update m2crypto dependency for Ubuntu #302
base: master
Are you sure you want to change the base?
Conversation
Update python-m2crypto to python3-m2crypto to include Python 3 support which is standard in Ubuntu 20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build absolutely worked for me. The check you failed must be on their end (looking for some dependency that isn't actually required for the build).
Thank you for this! Should the debian list also be updated? |
The build fails for Ubuntu 18 (Which is what the test ran) but not Ubuntu 20. Been meaning to look into it further. Will try look at that again and update the readme file. |
Pull current changes
Pull new changes
I don't know the best way to approach this issue, but I understand what is happening now. Ubuntu 18 (what Github checks is using) does not have the package python3-m2crypto, Ubuntu 20 which is what I was using to build does have the package python3-m2crypto. https://packages.ubuntu.com/search?keywords=python3-m2crypto&searchon=names is only available for Ubuntu 20. This means if we pulled this commit in, it would break for anyone not running Ubuntu 20. I haven't encountered this type of issue before what is the best approach? Is there a correct way to have the requirements split out for different versions of Ubuntu for example? |
Pull Request Template
Description
Updated python-m2crypto to python3-m2crypto, Python 3 is now the default for Ubuntu 20.
Fixes # (issue)
#300
How Has This Been Tested?
Updated dependencies.yaml and built from source.