remove gloo prefix for deployed objs #10629
Merged
+23
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgadban
force-pushed
the
law/remove-prefix
branch
from
8649f65 to
f88d412
Compare
timflannagan
approved these changes
Feb 14, 2025
jenshu
reviewed
Feb 14, 2025
| @@ -31,7 +31,7 @@ If release name contains chart name it will be used as a full name. | |||
| {{- .Values.gateway.fullnameOverride | trunc 63 | trimSuffix "-" }} | |||
| {{- else }} | |||
| {{- $name := default .Release.Name .Values.gateway.nameOverride }} | |||
| {{- .Release.Name | printf "gloo-proxy-%s" | trunc 63 | trimSuffix "-" }} | |||
There was a problem hiding this comment.
thre are a couple other places we could clean up like
devel/architecture/istio-integration.md
internal/kgateway/README.md
(not sure if those readmes themselves are up to date, but they have gloo-proxy references)
also all the e2e tests but i can take care of that as part of the current e2e cleanup/refactor
There was a problem hiding this comment.
i'll clean these up in this PR and leave anything in test/ for when they are wired back up
jenshu
approved these changes
Feb 14, 2025
lgadban
force-pushed
the
law/remove-prefix
branch
from
f88d412 to
ec056e9
Compare
timflannagan
approved these changes
Feb 14, 2025
jenshu
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.