Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs maintainers #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenshu
Copy link
Contributor

@jenshu jenshu commented Feb 11, 2025

Update the org.yaml and maintainers file to reflect the full list of docs maintainers (the yaml was not previously hooked up to the repo so they were out of sync)

Fixes #71

@jenshu jenshu requested review from a team, ilevine, ilrudie, linsun and yuval-k as code owners February 11, 2025 01:09
description: Maintainers of the kgateway.dev repo
maintainers:
- linsun
- williamgrh
members:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you meam to remove this line?

Copy link
Contributor Author

@jenshu jenshu Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, those are org admins so they need to go under the maintainers section otherwise peribolos complains. everyone under members has maintain privileges in the repo as specified on line 89 below (the naming is confusing)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, so this is members of the maintainer group, as opposed to members of the org.
and maintainers of the maintainers group can do something else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainers of a team may "click ops" a user into the team. They really shouldn't because our automation will revert that if the org.yaml doesn't get updated (and it will handle whatever you clicked in with the GUI when org.yaml is updated so it's really just extra work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation-maintainers are not linked to any repo
4 participants