-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs maintainers #74
base: main
Are you sure you want to change the base?
Conversation
description: Maintainers of the kgateway.dev repo | ||
maintainers: | ||
- linsun | ||
- williamgrh | ||
members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you meam to remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, those are org admins so they need to go under the maintainers
section otherwise peribolos complains. everyone under members
has maintain
privileges in the repo as specified on line 89 below (the naming is confusing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, so this is members of the maintainer group, as opposed to members of the org.
and maintainers of the maintainers group can do something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainers of a team may "click ops" a user into the team. They really shouldn't because our automation will revert that if the org.yaml doesn't get updated (and it will handle whatever you clicked in with the GUI when org.yaml is updated so it's really just extra work).
Update the org.yaml and maintainers file to reflect the full list of docs maintainers (the yaml was not previously hooked up to the repo so they were out of sync)
Fixes #71