Add OpenVINO backend support for argmin and argmax #21060

Hmm-1224 · 2025-03-18T05:28:20Z

@rkazants please check out this PR

codecov-commenter · 2025-03-18T05:36:09Z

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (7ed8edb) to head (eb5eb94).

Files with missing lines	Patch %	Lines
keras/src/backend/openvino/numpy.py	77.77%	4 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21060      +/-   ##
==========================================
- Coverage   82.70%   82.70%   -0.01%     
==========================================
  Files         564      564              
  Lines       54159    54195      +36     
  Branches     8414     8422       +8     
==========================================
+ Hits        44792    44820      +28     
- Misses       7294     7298       +4     
- Partials     2073     2077       +4

Flag	Coverage Δ
keras	`82.51% <77.77%> (-0.01%)`	⬇️
keras-jax	`64.02% <0.00%> (-0.05%)`	⬇️
keras-numpy	`59.04% <0.00%> (-0.04%)`	⬇️
keras-openvino	`32.96% <77.77%> (+0.04%)`	⬆️
keras-tensorflow	`64.30% <0.00%> (-0.05%)`	⬇️
keras-torch	`64.06% <0.00%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Hmm-1224 · 2025-03-22T20:01:00Z

hello @rkazants,
please check out this PR and guide me further .....

Hmm-1224 · 2025-03-24T18:25:31Z

Hey @rkazants,
As we are approaching the final stages of GSoC 2025, I’m truly passionate about contributing to OpenVINO and would love to successfully complete this PR as a prerequisite..

keras/src/backend/openvino/excluded_concrete_tests.txt

keras/src/backend/openvino/numpy.py

keras/src/backend/openvino/excluded_concrete_tests.txt

Hmm-1224 · 2025-03-29T09:29:17Z

hey @rkazants,
please check it out. i guess i made all mandatory changes u suggested..

Hmm-1224 · 2025-03-29T09:32:16Z

Why is this coming ? since i removed argmax argmin the no. of lines reduced and last line come at 164 from 168..then why is it creating issue?

keras/src/backend/openvino/numpy.py

rkazants · 2025-04-06T14:26:41Z

@Hmm-1224, I still see a lot undesired changes. Please always verify "Files changed" tab:

Hmm-1224 · 2025-04-07T13:52:45Z

@rkazants,
Hello sir... So far you helped a lot. Tomorrow(8th apr) is the deadline please help some more in completing this task.
I verify everything with master and only hstack implementation was unnecessary which i removed. Please tell what i have to remove exactly....

Hmm-1224 · 2025-04-08T06:35:32Z

Hello @rkazants,
Everything is now clear in "files changed". please check...

keras/src/backend/openvino/excluded_concrete_tests.txt

rkazants

@fchollet, looks good to me. Recommend to merge

Hmm-1224 · 2025-04-08T10:51:20Z

@rkazants,
Sir, anything I am required to do now...

rkazants · 2025-04-08T11:30:28Z

@rkazants, Sir, anything I am required to do now...

No. We anticipate approval and merge from @fchollet.

Hmm-1224 · 2025-04-08T12:27:09Z

Okay. Thanks a lot for guiding me and showing patience..

fchollet

LGTM, thanks! Sorry for the delay in merging.

Hmm-1224 · 2025-04-09T03:08:56Z

@fchollet , Thank you sir for merging this.

* Update numpy.py * Update excluded_concrete_tests.txt * all issues fixed * Update numpy.py * numpy.py reformatted * Update excluded_concrete_tests.txt * Update excluded_concrete_tests.txt * Update excluded_concrete_tests.txt * Update excluded_concrete_tests.txt * Update excluded_concrete_tests.txt * Update excluded_concrete_tests.txt

Hmm-1224 added 2 commits March 13, 2025 17:57

Update numpy.py

5bce71d

Update excluded_concrete_tests.txt

6fb3be2

google-ml-butler bot added the size:L label Mar 18, 2025

google-ml-butler bot assigned gbaned Mar 18, 2025

Hmm-1224 mentioned this pull request Mar 18, 2025

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.hstack operation openvinotoolkit/openvino#29361

Open

gbaned requested a review from mattdangerw March 18, 2025 11:55

google-ml-butler bot added the awaiting review label Mar 18, 2025

gbaned added this to PR Queue Mar 18, 2025

github-project-automation bot moved this to Assigned Reviewer in PR Queue Mar 18, 2025

Hmm-1224 mentioned this pull request Mar 22, 2025

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.argmax and numpy.argmin operations openvinotoolkit/openvino#29011

Closed

rkazants reviewed Mar 27, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Outdated Show resolved Hide resolved

rkazants reviewed Mar 27, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Outdated Show resolved Hide resolved

rkazants reviewed Mar 27, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Show resolved Hide resolved

rkazants reviewed Mar 27, 2025

View reviewed changes

keras/src/backend/openvino/numpy.py Outdated Show resolved Hide resolved

Hmm-1224 requested a review from rkazants March 27, 2025 10:21

rkazants reviewed Mar 28, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Outdated Show resolved Hide resolved

rkazants reviewed Mar 28, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Outdated Show resolved Hide resolved

Hmm-1224 requested a review from rkazants March 28, 2025 06:19

This comment was marked as off-topic.

Sign in to view

rkazants reviewed Apr 3, 2025

View reviewed changes

keras/src/backend/openvino/numpy.py Outdated Show resolved Hide resolved

rkazants reviewed Apr 3, 2025

View reviewed changes

keras/src/backend/openvino/numpy.py Outdated Show resolved Hide resolved

rkazants reviewed Apr 3, 2025

View reviewed changes

keras/src/backend/openvino/numpy.py Outdated Show resolved Hide resolved

Hmm-1224 requested a review from rkazants April 3, 2025 19:20

rkazants reviewed Apr 4, 2025

View reviewed changes

keras/src/backend/openvino/numpy.py Outdated Show resolved Hide resolved

Hmm-1224 requested a review from rkazants April 4, 2025 09:46

Hmm-1224 and others added 2 commits April 6, 2025 21:14

Update numpy.py

a3e9357

numpy.py reformatted

a944e17

Hmm-1224 added 6 commits April 8, 2025 10:45

Merge branch 'master' into Hmm-1224-patch-1

8770714

Update excluded_concrete_tests.txt

06f448b

Update excluded_concrete_tests.txt

7d5c6ee

Update excluded_concrete_tests.txt

d84ce1d

Update excluded_concrete_tests.txt

107f9de

Update excluded_concrete_tests.txt

df3e0ae

rkazants reviewed Apr 8, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Outdated Show resolved Hide resolved

rkazants reviewed Apr 8, 2025

View reviewed changes

keras/src/backend/openvino/excluded_concrete_tests.txt Outdated Show resolved Hide resolved

Update excluded_concrete_tests.txt

eb5eb94

Hmm-1224 requested a review from rkazants April 8, 2025 07:37

rkazants reviewed Apr 8, 2025

View reviewed changes

fchollet approved these changes Apr 9, 2025

View reviewed changes

google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 9, 2025

github-project-automation bot moved this from Assigned Reviewer to Approved by Reviewer in PR Queue Apr 9, 2025

fchollet merged commit ea84f00 into keras-team:master Apr 9, 2025
7 checks passed

google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Apr 9, 2025

github-project-automation bot moved this from Approved by Reviewer to Merged in PR Queue Apr 9, 2025

google-ml-butler bot removed the kokoro:force-run label Apr 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OpenVINO backend support for argmin and argmax #21060

Add OpenVINO backend support for argmin and argmax #21060

Hmm-1224 commented Mar 18, 2025

codecov-commenter commented Mar 18, 2025 •

edited

Loading

Hmm-1224 commented Mar 22, 2025

Hmm-1224 commented Mar 24, 2025 •

edited

Loading

Hmm-1224 commented Mar 29, 2025

Hmm-1224 commented Mar 29, 2025 •

edited

Loading

This comment was marked as off-topic.

rkazants commented Apr 6, 2025

Hmm-1224 commented Apr 7, 2025

Hmm-1224 commented Apr 8, 2025 •

edited

Loading

rkazants left a comment

Hmm-1224 commented Apr 8, 2025

rkazants commented Apr 8, 2025

Hmm-1224 commented Apr 8, 2025

fchollet left a comment

Hmm-1224 commented Apr 9, 2025

Add OpenVINO backend support for argmin and argmax #21060

Add OpenVINO backend support for argmin and argmax #21060

Conversation

Hmm-1224 commented Mar 18, 2025

codecov-commenter commented Mar 18, 2025 • edited Loading

Codecov Report

Hmm-1224 commented Mar 22, 2025

Hmm-1224 commented Mar 24, 2025 • edited Loading

Hmm-1224 commented Mar 29, 2025

Hmm-1224 commented Mar 29, 2025 • edited Loading

This comment was marked as off-topic.

rkazants commented Apr 6, 2025

Hmm-1224 commented Apr 7, 2025

Hmm-1224 commented Apr 8, 2025 • edited Loading

rkazants left a comment

Choose a reason for hiding this comment

Hmm-1224 commented Apr 8, 2025

rkazants commented Apr 8, 2025

Hmm-1224 commented Apr 8, 2025

fchollet left a comment

Choose a reason for hiding this comment

Hmm-1224 commented Apr 9, 2025

codecov-commenter commented Mar 18, 2025 •

edited

Loading

Hmm-1224 commented Mar 24, 2025 •

edited

Loading

Hmm-1224 commented Mar 29, 2025 •

edited

Loading

Hmm-1224 commented Apr 8, 2025 •

edited

Loading