Skip to content

Apply backend.result_type to equal, exp, expm1, full, greater* and less* #18636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

james77777778
Copy link
Contributor

Followed by #18482

The corresponding unit tests have also been added.

The principles in my mind, which are derived from the previous discussion:

  • match the type inference of JAX
  • if the integer input becomes a floating point output, use backend.floatx()
  • try to support all dtypes in all backends (even if it introduces some overhead for checking)

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the great contribution!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 17, 2023
@fchollet fchollet merged commit 0004264 into keras-team:master Oct 17, 2023
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Oct 17, 2023
@james77777778 james77777778 deleted the apply-result-type branch October 18, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants