Fix dtype bug in image converter #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question though: is it okay to do image preprocessing in |
mattdangerw
reviewed
Mar 17, 2025
| else: | ||
| return np.expand_dims(value, broadcast_dims) | ||
| return np.expand_dims(value, broadcast_dims).astype(inputs.dtype) |
There was a problem hiding this comment.
You might to call standardize dtype here, looks like tf dtypes are causing issues.
There was a problem hiding this comment.
It's weird that the tests are not failing locally
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Mar 30, 2025
This reverts commit e9241dd.
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Mar 30, 2025
This reverts commit e9241dd.
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Apr 1, 2025
This reverts commit e9241dd.
abheesht17
pushed a commit
that referenced
this pull request
Apr 3, 2025
abheesht17
pushed a commit
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pass
bfloat16as the dtype in image converter and call it, it fails. Here's a Colab to demonstrate this.Still curious why our preset tests for PaliGemma don't fail on GH Actions. Edit: Oh, it is because we don't run "large" tests: https://github.com/keras-team/keras-hub/blob/master/.github/workflows/actions.yml#L63.