numpy to keras ops #2126
Draft
numpy to keras ops #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
reviewed
Mar 20, 2025
| @@ -6,8 +6,10 @@ | |||
|
|
|||
| try: | |||
| import tensorflow as tf | |||
| import keras.ops as ops | |||
There was a problem hiding this comment.
No reason to import keras conditionally. We don't want to assume tf is install, we can assume keras is installed.
| @@ -242,4 +248,4 @@ def get_config(self): | |||
| "max_audio_length": self.max_audio_length, | |||
| } | |||
| ) | |||
| return config | |||
| return config | |||
There was a problem hiding this comment.
don't remove training newline
| @@ -84,6 +86,20 @@ def audio_shape(self): | |||
| """Returns the preprocessed size of a single audio sample.""" | |||
| return (self.max_audio_length, self.num_mels) | |||
|
|
|||
|
|
|||
|
|
|||
| def _get_rfftfreq_keras(self): # Inside the class definition | |||
There was a problem hiding this comment.
what is this comment support to mean?
| @@ -92,25 +108,15 @@ def _get_mel_filters(self): | |||
|
|
|||
| # TODO: Convert to TensorFlow ops (if possible). | |||
There was a problem hiding this comment.
We should remove this TODO I think.
| logstep * (mels[log_t] - min_log_mel) | ||
| ) | ||
|
|
||
| freqs = ops.where(log_t, min_log_hz * ops.exp(logstep * (mels - min_log_mel)), freqs) # using tf.where for conditional replacement |
There was a problem hiding this comment.
remove the comment, and reformat to 80 chars
| mel_f = freqs | ||
|
|
||
| fdiff = np.diff(mel_f) | ||
| ramps = np.subtract.outer(mel_f, fftfreqs) | ||
| fdiff = mel_f[1:] - mel_f[:-1] #keras diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mel_filters function was successfully migrated to Keras ops, replacing NumPy. All tests now pass, ensuring consistent performance within the Keras framework.