Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gacha getting stuck #423

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Fix gacha getting stuck #423

merged 4 commits into from
Nov 13, 2024

Conversation

ker0olos
Copy link
Owner

An issue that happened with community pack characters that have a set specific rating during pool character validation

@ker0olos ker0olos added the hotfix A hotfix PR label Nov 13, 2024
@ker0olos ker0olos self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (00eac27) to head (27cd155).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tower.ts 0.00% 4 Missing ⚠️
src/gacha.ts 50.00% 3 Missing ⚠️
src/interactions.ts 50.00% 2 Missing ⚠️
src/discord.ts 0.00% 1 Missing ⚠️
src/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   80.37%   79.53%   -0.84%     
==========================================
  Files          44       44              
  Lines       12486    12028     -458     
  Branches     1410     1412       +2     
==========================================
- Hits        10036     9567     -469     
- Misses       2430     2440      +10     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ker0olos ker0olos merged commit 33a53bc into main Nov 13, 2024
7 of 9 checks passed
@ker0olos ker0olos deleted the hotfix branch November 13, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix A hotfix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant